feature flag lazy runeDocSection decoding#312
Merged
keegancsmith merged 2 commits intomasterfrom Apr 6, 2022
Merged
Conversation
keegancsmith
force-pushed
the
k/disable-lazy
branch
from
25616f9 to
2308d91
Compare
Currently this takes up 30% of production CPU. We are unsure if its worth the tradeoff so we will experiment with enabling vs disabling and measure the impact. We default to the current behaviour. To disable you set the environment variable ZOEKT_DISABLE_LAZY_DOC_SECTIONS to a non empty value. Test Plan: locally run zoekt-webserver with and without the feature flag. With the feature flag we should have higher memory usage. Ensure in both cases symbol search works.
keegancsmith
force-pushed
the
k/disable-lazy
branch
from
2308d91 to
6f81078
Compare
stefanhengl
approved these changes
Apr 5, 2022
| Shards: 1, | ||
| Documents: 4, | ||
| IndexBytes: 308, | ||
| IndexBytes: 300, |
Member
There was a problem hiding this comment.
We could instead udpate memoryUse like this
- sz += 8 * len(d.runeDocSections)
+ sz += 8 * len(d.runeDocSectionsRaw)
Member
Author
There was a problem hiding this comment.
if its the raw section then it is mmap and isn't part of our stable memory usage.
camdencheek
reviewed
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this takes up 30% of production CPU. We are unsure if its worth the tradeoff so we will experiment with enabling vs disabling and measure the impact.
We default to the current behaviour. To disable you set the environment variable ZOEKT_DISABLE_LAZY_DOC_SECTIONS to a non empty value.
Test Plan: locally run zoekt-webserver with and without the feature flag. With the feature flag we should have higher memory usage. Ensure in both cases symbol search works.