Conversation
gruuya
force-pushed
the
external-catalog
branch
from
42ab9bd to
6ce1526
Compare
Also rename floc crate to clade.
gruuya
force-pushed
the
external-catalog
branch
from
6ce1526 to
a565470
Compare
clade/proto/schema.proto
Outdated
|
|
||
| service SchemaStoreService { | ||
| // List the available schemas | ||
| rpc List(catalog.CatalogReference) returns (ListSchemaResponse); |
There was a problem hiding this comment.
I think a best practice here is naming these types as per the method (https://protobuf.dev/programming-guides/style/#message-field-names), e.g. GetCatalog(GetCatalogRequest) returns (GetCatalogResponse)
| pub const DEFAULT_SCHEMA: &str = "public"; | ||
| pub const STAGING_SCHEMA: &str = "staging"; | ||
|
|
||
| #[derive(Debug, thiserror::Error)] |
There was a problem hiding this comment.
actual error handling library, nice
tests/clade/query.rs
Outdated
| let (context, clade) = start_clade_server().await; | ||
| tokio::task::spawn(clade); | ||
|
|
||
| tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; |
There was a problem hiding this comment.
mmmmm is there no better way to wait until it's up and running? this can randomly fail if something is having a slow day
clade/Cargo.toml
Outdated
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
|
There was a problem hiding this comment.
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
| @@ -0,0 +1,13 @@ | |||
| [package] | |||
| name = "clade" | |||
There was a problem hiding this comment.
Might as well keep calling it clade, though we might need to get more people involved in naming it if we ever want to spin it out into a separate open source project. (alternative name: simply seafowl-metastore)
|
Added the metadata required to expose a reflection service (useful for GUI gRPC clients): #484 |
2 participants
External metastore support via a gRPC interface, Closes #485.