Skip to content

Comments

Add logout button#122

Merged
smacker merged 2 commits intosrc-d:masterfrom
smacker:logout_button
Feb 16, 2018
Merged

Add logout button#122
smacker merged 2 commits intosrc-d:masterfrom
smacker:logout_button

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented Feb 15, 2018

Fixes: #117

we don't have it on wireframes, so I added it using default bootstrap components and styled dropdown to match overriden theme.

Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker requested a review from bzz February 15, 2018 14:34
@bzz
Copy link
Contributor

bzz commented Feb 15, 2018

@smacker 🙏 🙏 a screenshot

@bzz bzz requested a review from dpordomingo February 15, 2018 15:11
@smacker
Copy link
Contributor Author

smacker commented Feb 15, 2018

Collapsed:
screen shot 2018-02-15 at 16 11 51

Clicked:
screen shot 2018-02-15 at 16 11 59

This component: https://react-bootstrap.github.io/components/navbar/#navbars-basic

@ricardobaeta
Copy link
Contributor

ricardobaeta commented Feb 15, 2018

@smacker Please be so kind to use the @brand-info colour for that dropdown icon, or use the .svg.

Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker
Copy link
Contributor Author

smacker commented Feb 15, 2018

@ricardobaeta done.

@smacker smacker merged commit 3e6fe9f into src-d:master Feb 16, 2018
@bzz bzz mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants