Skip to content

Comments

Lines of code#138

Merged
smacker merged 2 commits intosrc-d:masterfrom
smacker:lines_of_code
Feb 19, 2018
Merged

Lines of code#138
smacker merged 2 commits intosrc-d:masterfrom
smacker:lines_of_code

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented Feb 16, 2018

Fix: #133

Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker requested a review from bzz February 16, 2018 19:08
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always attach screenshots to PR that changes the UI

@smacker
Copy link
Contributor Author

smacker commented Feb 16, 2018

screen shot 2018-02-16 at 22 39 10

Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

👍 for a screenshot for UI changes!

@smacker smacker merged commit 723a3c6 into src-d:master Feb 19, 2018
@bzz bzz mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants