Merged
Conversation
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
dpordomingo
approved these changes
Feb 27, 2018
Contributor
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
LGTM
But we should avoid these kind of functions which doesn't fit in a window without scrolling, reuses variables inside it's scope and does different things. For example, I think this bug would be avoided if the existence of the Experiment would have been checked in a separated —and smaller— function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While importing new file pairs SQLite to SQLite I was getting the error message "database is locked".
This commit fixes it closing the first connection instead of deferring it.