Merged
Conversation
carlosms
reviewed
Mar 1, 2018
server/repository/experiments.go
Outdated
| return results, nil | ||
| } | ||
|
|
||
| // Create experiment model in database |
Contributor
There was a problem hiding this comment.
I'd mention that the new ID is also set.
// Create stores an Experiment in database. On success the assigned ID is set
bzz
approved these changes
Mar 1, 2018
Contributor
bzz
left a comment
bzz
left a comment
There was a problem hiding this comment.
lgtm
👍 for having tests
Probably a nit-pick, but having changes with refactoring in a separate commit from the changes that adds new functionality would make this PR even better.
Merged
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Contributor
Author
|
rebase, squshed, merging after CI is green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements endpoint needed for #160