Merge initial work into official initial commit#7
Conversation
src/logo.svg
Outdated
| @@ -0,0 +1,7 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 841.9 595.3"> | |||
There was a problem hiding this comment.
From https://github.com/facebook/react/blob/master/LICENSE this logo seems to be MIT licensed, which is compatible with GPL3 but we would need to track this somewhere, if we start mixing licenses inside a single codebase.
I would suggest we either remove it, or replace it with something we own, that can be covered by GPL 3 as everything else in this repo.
|
Looks great to me, sans minor potential licensing issue noted above. |
a16cd3c to
4c7b9e9
Compare
|
It's enough not to have it in the version of the source code, that will be distributed. It's actually preferable to have it in the history with excellent commit message on how it's been taken care of, before it became an issue. Thank you @dpordomingo for taking care of it - looks great to me. |
No description provided.