Merged
Conversation
Contributor
|
I believe that macosx VMs are slower and the timeout is not big enough so it fails. Do you think this is enough or we should add an integration test with real postgres? At some point we need integration test also downloading a real organization. |
Contributor
Author
|
I'll play with the times to make it work in the CI. For now I think it's enough to test the core functionality (things from gitcollector side are working as they should do) but for sure in the future we will need integration tests to check that wherever metrics are exported they are managed correctly. |
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
mcarmonaa
force-pushed
the
improvement/test-metrics
branch
from
6d23e4b to
470202d
Compare
Contributor
Author
|
@jfontan CI now passes |
jfontan
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52