Merged
Conversation
add cases with handling timeouts, immediate stops and send metrics errors Signed-off-by: lwsanty <lwsanty@gmail.com>
jfontan
reviewed
Sep 17, 2019
| {"NonImmediateWithoutDelay", false, time.Second, 0, 1}, | ||
| {"NonImmediateWithDelay", false, 500 * time.Millisecond, time.Second, 2}, | ||
| } { | ||
| c := c |
Contributor
There was a problem hiding this comment.
Why this variable copy/shadowing?
Contributor
Author
There was a problem hiding this comment.
probably it's a habit left after scopelint :)
Contributor
There was a problem hiding this comment.
I didn't know about that linter 👍
Contributor
Author
There was a problem hiding this comment.
this one is a part of golangci-lint
we could probably use it if we have a need in linters, however we should consider that they consume too much RAM
jfontan
approved these changes
Sep 17, 2019
mcarmonaa
approved these changes
Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add cases with handling timeouts, immediate stops and send metrics errors
Signed-off-by: lwsanty lwsanty@gmail.com