Conversation
jfontan
approved these changes
Sep 18, 2019
mcarmonaa
reviewed
Sep 20, 2019
Contributor
mcarmonaa
left a comment
mcarmonaa
left a comment
There was a problem hiding this comment.
Other than the not very important comment I left, LGTM!
| removePaths(h.cmd.TmpPath, h.cmd.LibPath) | ||
| } | ||
|
|
||
| func preparePostgres() (string, func(), error) { |
Contributor
There was a problem hiding this comment.
can we add a comment to see at first glance that the returned function is for closing/cleaning up purpose?
Signed-off-by: lwsanty <lwsanty@gmail.com>
lwsanty
force-pushed
the
pq_integration_tests
branch
from
792d4bd to
eef5382
Compare
mcarmonaa
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lwsanty lwsanty@gmail.com