Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Comments

function: make array_length not fail with literal null#767

Merged
ajnavarro merged 2 commits intosrc-d:masterfrom
erizocosmico:fix/null-array-length
Jun 24, 2019
Merged

function: make array_length not fail with literal null#767
ajnavarro merged 2 commits intosrc-d:masterfrom
erizocosmico:fix/null-array-length

Conversation

@erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Jun 24, 2019

Fixes #766

@erizocosmico erizocosmico requested a review from a team June 24, 2019 10:55
ajnavarro
ajnavarro reviewed Jun 24, 2019
View reviewed changes
@erizocosmico erizocosmico force-pushed the fix/null-array-length branch from 38fdc19 to 0d7d5a1 Compare June 24, 2019 13:25
@ajnavarro
Copy link
Contributor

ajnavarro commented Jun 24, 2019

@erizocosmico we need to change tests to handle the new no-errors case:

--- FAIL: TestArrayLength (0.00s)
    --- PASS: TestArrayLength/array_is_nil (0.00s)
    --- PASS: TestArrayLength/array_is_not_of_right_type (0.00s)
    --- PASS: TestArrayLength/array_is_ok (0.00s)
    require.go:248: 
        	Error Trace:	arraylength_test.go:44
        	Error:      	An error is expected but got nil.
        	Test:       	TestArrayLength

@erizocosmico
function: make array_length not fail with literal null
e2905cd 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico force-pushed the fix/null-array-length branch from 0d7d5a1 to e2905cd Compare June 24, 2019 13:50
@erizocosmico
Copy link
Contributor Author

erizocosmico commented Jun 24, 2019

Fixed

@ajnavarro ajnavarro merged commit 8702d43 into src-d:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ARRAY_LENGTH is not handling null values well

4 participants

@erizocosmico @ajnavarro @juanjux @kuba--