Publish arm64 binaries for linux/mac/windows#701
Publish arm64 binaries for linux/mac/windows#701charlesoconor wants to merge 3 commits intostackrox:mainfrom
Conversation
.github/workflows/build.yaml
Outdated
| asset_path: linux/kube-linter-linux | ||
| asset_name: kube-linter-linux | ||
| asset_path: linux/amd64/kube-linter-linux-amd64 | ||
| asset_name: kube-linter-linux-amd64 |
There was a problem hiding this comment.
this will be a breaking change all users who download with a script need to update
There was a problem hiding this comment.
Do you want to upload a kube-linter-linux as well as a kube-linter-linux-amd64 for backwards compatibility?
There was a problem hiding this comment.
I think we should keep it backward compatible for a one or two releases
.github/workflows/build.yaml
Outdated
| asset_path: linux/kube-linter-linux | ||
| asset_name: kube-linter-linux | ||
| asset_path: linux/amd64/kube-linter-linux-amd64 | ||
| asset_name: kube-linter-linux-amd64 |
There was a problem hiding this comment.
Do you want to upload a kube-linter-linux as well as a kube-linter-linux-amd64 for backwards compatibility?
scripts/go-build.sh
Outdated
| [[ -n "${GOARCH}" ]] || die "GOARCH must be set" | ||
| bin_name="$(basename "$main_srcdir")" | ||
| output_file="bin/${GOOS}/${bin_name}" | ||
| output_file="bin/${GOOS}/${GOARCH}/${bin_name}" |
There was a problem hiding this comment.
Could change this to be part of the file if that makes more sense.
| output_file="bin/${GOOS}/${GOARCH}/${bin_name}" | |
| output_file="bin/${GOOS}/${bin_name}-${GOARCH}" |
Makefile
Outdated
| @CGO_ENABLED=0 GOARCH=amd64 GOOS=darwin scripts/go-build.sh ./cmd/kube-linter | ||
| @CGO_ENABLED=0 GOARCH=arm64 GOOS=darwin scripts/go-build.sh ./cmd/kube-linter | ||
| @CGO_ENABLED=0 GOARCH=amd64 GOOS=linux scripts/go-build.sh ./cmd/kube-linter | ||
| @CGO_ENABLED=0 GOARCH=arm64 GOOS=linux scripts/go-build.sh ./cmd/kube-linter | ||
| @CGO_ENABLED=0 GOARCH=amd64 GOOS=windows scripts/go-build.sh ./cmd/kube-linter | ||
| @CGO_ENABLED=0 GOARCH=arm64 GOOS=windows scripts/go-build.sh ./cmd/kube-linter |
There was a problem hiding this comment.
I think we should split this similar to how it's done https://github.com/stackrox/stackrox/blob/82304c1669be79a3049d886f7e46145de4004a6c/Makefile#L390-L402
janisz
left a comment
janisz
left a comment
There was a problem hiding this comment.
Nice, I think we need to keep old linux file name and we are ready to ship it. Ultimately we probably would replace Makefile and workflow with https://goreleaser.com as it does everything we want
Fixes: stackrox#691 Fixes: stackrox#404
Got dropped in a rebase
charlesoconor
force-pushed
the
feature/DE-3-publish-arm64-binaries
branch
from
3a38486 to
5564d1f
Compare
Update name to have `-$(arch)` instead of in dir path.
charlesoconor
force-pushed
the
feature/DE-3-publish-arm64-binaries
branch
from
5564d1f to
5992791
Compare
|
How about usign goreleaser for this #720 |
It makes sense. I can close this out. |
|
@charlesoconor You may like to see |
2 participants
Fixes: #691
Fixes: #404