Merged
Conversation
01f0f14 to
98254b1
Compare
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
98254b1 to
47ebcfb
Compare
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
commented
Feb 16, 2024
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
commented
Feb 16, 2024
janisz
commented
Feb 16, 2024
dhaus67
reviewed
Feb 19, 2024
.github/workflows/release.yaml
Outdated
| # Install the cosign tool except on PR | ||
| # https://github.com/sigstore/cosign-installer | ||
| - name: Install cosign | ||
| if: github.event_name != 'pull_request' |
Contributor
There was a problem hiding this comment.
Wondering if we need that since we only run this on tags and push? (applies to all occurrences)
Co-authored-by: dhaus67 <dhaus@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage ? 72.36%
=======================================
Files ? 45
Lines ? 1936
Branches ? 0
=======================================
Hits ? 1401
Misses ? 421
Partials ? 114 ☔ View full report in Codecov by Sentry. |
dhaus67
approved these changes
Feb 21, 2024
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
This was referenced Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using goreleaser will help us with releasing on different platforms.
This PR make it working like we used to have. In next PRs I'd like to add arm and if we like other platform support.
Tested:
https://github.com/janisz/kube-linter/releases/tag/v0.7.21