Allow comma-separated filenames in multi-chain configurations#1312
Allow comma-separated filenames in multi-chain configurations#1312
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
mitzimorris
left a comment
There was a problem hiding this comment.
LGTM!
this was more possible than I thought it would be, but still a lot of work. many thanks!
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Closes #1255. When num_chains > 1, we now allow the user to explicitly pass a comma separated list of names of exactly
num_chainslength to opt-out of our current behavior where we take the name they provide and munge it by appending _IDIntended Effect:
Make the command line interface easier to use with multiple inputs or outputs.
How to Verify:
The following command is now possible:
this will produce the chains with the specified output names, rather than the behavior if output file was omitted, which is equivalent to
output file=output_3.csv,output_4.csv,output_5.csv,output_6.csvSide Effects:
Hopefully, none.
Documentation:
TBD
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: