Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
These were never really doing the right thing anyway!
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Submission Checklist
./runCmdStanTests.py src/testSummary:
Attempts to improve the situation in cases like #1310
Intended Effect:
How to Verify:
I don't know a good way of simulating out-of-disk-space directly. You can test on other situations, like unwritable files or
similar. In those cases, you should see:
$ ls -lha # note there is no `w` bit for test_outputs/ -rwxrwxr-x 1 brian brian 2.6M Mar 12 16:27 bernoulli -rw-rw-r-- 1 brian brian 50 Jun 6 2024 bernoulli.data.json dr-xr-xr-x 2 brian brian 4.0K Mar 12 16:25 test_outputs $ ./bernoulli sample data file=bernoulli.data.json output file=test_outputs/foo.csv basic_ios::clear: iostream error: Permission deniedThe "Permission denied" is new in this PR.
Side Effects:
CmdStan now halts in more erroneous situations, such as the above where the output is not writable; in the current code, it happily runs and just produces no outputs.
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: