Conversation
|
preliminary PR, still need to update docs and write some unit tests. I've plumbed in the minimal changes necessary to get this feature to work. the stansummary code really needs to be cleaned up / refactored. opinions on how much to do for this PR? |
|
@rok-cesnovar - many thanks for your help and explanations! |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
2fa511e to
a79fca5
Compare
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
rok-cesnovar
left a comment
There was a problem hiding this comment.
The windows makefile gods required some more worship. Its working now.
| endif | ||
| endif | ||
| BOOST_PROGRAM_OPTIONS_LIB=$(BOOST)/stage/lib/libboost_program_options*.a | ||
| BOOST_BUILD_OPTS=--toolset=$(CXX_TYPE) address-model=$(WINBITNESS) |
There was a problem hiding this comment.
All this logic is required so we only build one .a file (the one with the bit-ness of the system). On windows boost otherwise builds two files and the filename is libboost_program_options-something-x64-1_72.a.
|
@rok-cesnovar many many thanks!!! beginning to consider you a windows makefile god. |
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Added new argument "-percentiles" which takes as value a string consisting
of a set of comma-separated integers between 0 and 100, which will be used
to get the quantiles for all values in the Stan csv output files.
Intended Effect:
see #888
How to Verify:
Test via command line:
no --percentiles arg specified, or --percentiles "5,50,95", - output same as current dev version.
--percentiles values "10,50,90", or "5,20,40,75,99" - etc - will output corresponding quantile values accordingly.
Side Effects:
Now using boost::program_options to parse args; makefile changed accordingly.
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia U
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: