Skip to content

Feature/888 stansummary ci arg#890

Merged
rok-cesnovar merged 47 commits intodevelopfrom
feature/888-stansummary-ci-arg
Jun 16, 2020
Merged

Feature/888 stansummary ci arg#890
rok-cesnovar merged 47 commits intodevelopfrom
feature/888-stansummary-ci-arg

Conversation

@mitzimorris
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Added new argument "-percentiles" which takes as value a string consisting
of a set of comma-separated integers between 0 and 100, which will be used
to get the quantiles for all values in the Stan csv output files.

Intended Effect:

see #888

How to Verify:

Test via command line:

  • no --percentiles arg specified, or --percentiles "5,50,95", - output same as current dev version.

  • --percentiles values "10,50,90", or "5,20,40,75,99" - etc - will output corresponding quantile values accordingly.

Side Effects:

Now using boost::program_options to parse args; makefile changed accordingly.

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia U
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris mitzimorris requested a review from rok-cesnovar June 13, 2020 01:43
@mitzimorris
Copy link
Member Author

preliminary PR, still need to update docs and write some unit tests.

I've plumbed in the minimal changes necessary to get this feature to work. the stansummary code really needs to be cleaned up / refactored. opinions on how much to do for this PR?

@mitzimorris
Copy link
Member Author

@rok-cesnovar - many thanks for your help and explanations!

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.08 4.1 0.99 -0.65% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.02 1.74% faster
eight_schools/eight_schools.stan 0.09 0.09 1.03 2.71% faster
gp_regr/gp_regr.stan 0.19 0.19 0.99 -1.13% slower
irt_2pl/irt_2pl.stan 5.23 5.26 0.99 -0.66% slower
performance.compilation 85.34 84.13 1.01 1.43% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.72 7.71 1.0 0.1% faster
pkpd/one_comp_mm_elim_abs.stan 20.29 20.97 0.97 -3.38% slower
sir/sir.stan 99.86 99.76 1.0 0.1% faster
gp_regr/gen_gp_data.stan 0.04 0.05 0.99 -1.29% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.02 1.0 0.07% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.32 0.97 -2.92% slower
arK/arK.stan 2.4 2.4 1.0 -0.04% slower
arma/arma.stan 0.6 0.59 1.01 1.44% faster
garch/garch.stan 0.58 0.58 1.0 -0.28% slower
Mean result: 0.998413024667

Jenkins Console Log
Blue Ocean
Commit hash: 4be5970


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.06 3.97 1.02 2.21% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.96 -4.18% slower
eight_schools/eight_schools.stan 0.09 0.09 1.0 0.45% faster
gp_regr/gp_regr.stan 0.19 0.19 1.0 -0.36% slower
irt_2pl/irt_2pl.stan 5.28 5.23 1.01 1.0% faster
performance.compilation 85.55 84.11 1.02 1.69% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.73 7.79 0.99 -0.72% slower
pkpd/one_comp_mm_elim_abs.stan 20.57 21.85 0.94 -6.2% slower
sir/sir.stan 97.34 92.61 1.05 4.86% faster
gp_regr/gen_gp_data.stan 0.04 0.05 0.97 -2.87% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.02 1.0 -0.08% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.32 0.96 -3.64% slower
arK/arK.stan 2.41 2.42 1.0 -0.3% slower
arma/arma.stan 0.6 0.59 1.01 0.98% faster
garch/garch.stan 0.58 0.59 1.0 -0.32% slower
Mean result: 0.995739643019

Jenkins Console Log
Blue Ocean
Commit hash: 19a2c60


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.04 4.09 0.99 -1.21% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.98 -2.51% slower
eight_schools/eight_schools.stan 0.09 0.09 1.0 -0.21% slower
gp_regr/gp_regr.stan 0.2 0.19 1.05 5.21% faster
irt_2pl/irt_2pl.stan 5.26 5.32 0.99 -1.09% slower
performance.compilation 85.64 84.26 1.02 1.6% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.78 7.73 1.01 0.65% faster
pkpd/one_comp_mm_elim_abs.stan 20.3 21.21 0.96 -4.48% slower
sir/sir.stan 91.22 103.11 0.88 -13.03% slower
gp_regr/gen_gp_data.stan 0.04 0.05 0.94 -5.97% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.03 3.02 1.0 0.24% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.31 1.02 1.92% faster
arK/arK.stan 2.4 2.41 1.0 -0.2% slower
arma/arma.stan 0.59 0.6 0.99 -0.63% slower
garch/garch.stan 0.58 0.59 1.0 -0.5% slower
Mean result: 0.988176112955

Jenkins Console Log
Blue Ocean
Commit hash: d109e6c


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.05 4.03 1.0 0.44% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.15% slower
eight_schools/eight_schools.stan 0.09 0.09 0.99 -0.63% slower
gp_regr/gp_regr.stan 0.19 0.19 0.99 -1.02% slower
irt_2pl/irt_2pl.stan 5.28 5.3 1.0 -0.34% slower
performance.compilation 85.47 84.17 1.02 1.52% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.79 7.71 1.01 1.08% faster
pkpd/one_comp_mm_elim_abs.stan 20.75 21.15 0.98 -1.93% slower
sir/sir.stan 92.74 103.34 0.9 -11.43% slower
gp_regr/gen_gp_data.stan 0.04 0.04 0.98 -1.85% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.04 3.02 1.0 0.48% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.31 1.0 0.44% faster
arK/arK.stan 2.4 2.44 0.98 -1.8% slower
arma/arma.stan 0.59 0.59 0.99 -0.67% slower
garch/garch.stan 0.58 0.59 1.0 -0.27% slower
Mean result: 0.990138541748

Jenkins Console Log
Blue Ocean
Commit hash: 901634e


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.09 3.95 1.04 3.5% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.97 -2.7% slower
eight_schools/eight_schools.stan 0.09 0.09 0.99 -1.39% slower
gp_regr/gp_regr.stan 0.19 0.19 0.98 -1.68% slower
irt_2pl/irt_2pl.stan 5.28 5.25 1.01 0.51% faster
performance.compilation 86.52 84.2 1.03 2.68% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.71 7.71 1.0 0.07% faster
pkpd/one_comp_mm_elim_abs.stan 20.39 21.13 0.97 -3.61% slower
sir/sir.stan 93.78 91.41 1.03 2.52% faster
gp_regr/gen_gp_data.stan 0.04 0.04 0.97 -2.69% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.07 0.98 -1.65% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.32 0.99 -0.75% slower
arK/arK.stan 2.44 2.41 1.01 1.07% faster
arma/arma.stan 0.59 0.59 1.0 0.32% faster
garch/garch.stan 0.59 0.59 1.0 -0.44% slower
Mean result: 0.997603674937

Jenkins Console Log
Blue Ocean
Commit hash: d734848


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.13 4.11 1.01 0.67% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.01 1.09% faster
eight_schools/eight_schools.stan 0.09 0.09 0.99 -0.8% slower
gp_regr/gp_regr.stan 0.19 0.19 1.0 -0.04% slower
irt_2pl/irt_2pl.stan 5.28 5.23 1.01 0.91% faster
performance.compilation 86.9 84.06 1.03 3.28% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.72 7.76 0.99 -0.62% slower
pkpd/one_comp_mm_elim_abs.stan 21.92 20.41 1.07 6.87% faster
sir/sir.stan 91.72 91.16 1.01 0.62% faster
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 -0.22% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.02 1.0 -0.06% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.31 1.01 0.9% faster
arK/arK.stan 2.41 2.42 0.99 -0.51% slower
arma/arma.stan 0.6 0.6 1.0 -0.35% slower
garch/garch.stan 0.58 0.59 1.0 -0.26% slower
Mean result: 1.00809815915

Jenkins Console Log
Blue Ocean
Commit hash: d734848


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.01 4.02 1.0 -0.19% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 0.22% faster
eight_schools/eight_schools.stan 0.09 0.09 0.96 -4.22% slower
gp_regr/gp_regr.stan 0.2 0.19 1.02 2.33% faster
irt_2pl/irt_2pl.stan 5.26 5.28 1.0 -0.4% slower
performance.compilation 85.34 84.2 1.01 1.34% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.69 7.72 1.0 -0.31% slower
pkpd/one_comp_mm_elim_abs.stan 21.26 20.94 1.01 1.47% faster
sir/sir.stan 93.59 98.55 0.95 -5.3% slower
gp_regr/gen_gp_data.stan 0.04 0.05 0.97 -3.56% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.04 0.99 -0.59% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.31 1.01 1.16% faster
arK/arK.stan 2.41 2.41 1.0 0.07% faster
arma/arma.stan 0.59 0.59 1.0 -0.16% slower
garch/garch.stan 0.59 0.58 1.01 1.48% faster
Mean result: 0.996022690617

Jenkins Console Log
Blue Ocean
Commit hash: 4f46896


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.99 4.03 0.99 -0.77% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.96 -3.84% slower
eight_schools/eight_schools.stan 0.09 0.09 1.0 -0.04% slower
gp_regr/gp_regr.stan 0.19 0.19 1.0 -0.27% slower
irt_2pl/irt_2pl.stan 5.25 5.27 1.0 -0.38% slower
performance.compilation 85.49 84.17 1.02 1.54% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.72 7.71 1.0 0.09% faster
pkpd/one_comp_mm_elim_abs.stan 20.67 21.03 0.98 -1.73% slower
sir/sir.stan 93.73 91.34 1.03 2.55% faster
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 0.23% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.03 3.02 1.0 0.11% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.33 0.96 -4.3% slower
arK/arK.stan 2.42 2.41 1.0 0.41% faster
arma/arma.stan 0.59 0.6 1.0 -0.4% slower
garch/garch.stan 0.58 0.59 1.0 -0.29% slower
Mean result: 0.995580534188

Jenkins Console Log
Blue Ocean
Commit hash: 51cdd4d


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.0 4.0 1.0 -0.09% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.02 2.1% faster
eight_schools/eight_schools.stan 0.09 0.09 1.0 -0.31% slower
gp_regr/gp_regr.stan 0.2 0.19 1.01 1.17% faster
irt_2pl/irt_2pl.stan 5.26 5.27 1.0 -0.21% slower
performance.compilation 86.74 84.57 1.03 2.5% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.78 7.73 1.01 0.7% faster
pkpd/one_comp_mm_elim_abs.stan 20.87 21.42 0.97 -2.64% slower
sir/sir.stan 96.39 99.62 0.97 -3.36% slower
gp_regr/gen_gp_data.stan 0.05 0.04 1.03 3.26% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 3.03 1.0 -0.39% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.33 0.99 -0.86% slower
arK/arK.stan 2.42 2.42 1.0 -0.03% slower
arma/arma.stan 0.6 0.59 1.0 0.46% faster
garch/garch.stan 0.59 0.59 1.0 -0.28% slower
Mean result: 1.00163833326

Jenkins Console Log
Blue Ocean
Commit hash: 51cdd4d


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar force-pushed the feature/888-stansummary-ci-arg branch from 2fa511e to a79fca5 Compare June 16, 2020 19:45
@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.02 4.02 1.0 0.09% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.46% slower
eight_schools/eight_schools.stan 0.09 0.09 1.0 -0.25% slower
gp_regr/gp_regr.stan 0.19 0.19 0.99 -0.54% slower
irt_2pl/irt_2pl.stan 5.26 5.34 0.99 -1.45% slower
performance.compilation 85.46 84.4 1.01 1.24% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.72 7.71 1.0 0.24% faster
pkpd/one_comp_mm_elim_abs.stan 20.32 20.76 0.98 -2.2% slower
sir/sir.stan 91.33 98.67 0.93 -8.04% slower
gp_regr/gen_gp_data.stan 0.05 0.04 1.03 2.67% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.03 3.03 1.0 0.1% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.32 0.32 1.02 1.69% faster
arK/arK.stan 2.43 2.44 1.0 -0.4% slower
arma/arma.stan 0.6 0.6 1.0 0.24% faster
garch/garch.stan 0.58 0.59 0.99 -0.54% slower
Mean result: 0.995463251544

Jenkins Console Log
Blue Ocean
Commit hash: a79fca5


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.99 4.06 0.98 -1.8% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.98 -2.36% slower
eight_schools/eight_schools.stan 0.09 0.09 1.06 6.04% faster
gp_regr/gp_regr.stan 0.2 0.19 1.03 2.74% faster
irt_2pl/irt_2pl.stan 5.3 5.27 1.01 0.55% faster
performance.compilation 86.65 84.53 1.03 2.45% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.69 7.71 1.0 -0.28% slower
pkpd/one_comp_mm_elim_abs.stan 20.19 21.09 0.96 -4.45% slower
sir/sir.stan 91.15 91.47 1.0 -0.36% slower
gp_regr/gen_gp_data.stan 0.04 0.04 0.98 -1.99% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.03 3.02 1.0 0.19% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.32 0.34 0.92 -8.42% slower
arK/arK.stan 2.4 2.42 0.99 -0.95% slower
arma/arma.stan 0.6 0.59 1.0 0.06% faster
garch/garch.stan 0.59 0.59 1.0 -0.07% slower
Mean result: 0.995241792986

Jenkins Console Log
Blue Ocean
Commit hash: a79fca5


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows makefile gods required some more worship. Its working now.

endif
endif
BOOST_PROGRAM_OPTIONS_LIB=$(BOOST)/stage/lib/libboost_program_options*.a
BOOST_BUILD_OPTS=--toolset=$(CXX_TYPE) address-model=$(WINBITNESS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this logic is required so we only build one .a file (the one with the bit-ness of the system). On windows boost otherwise builds two files and the filename is libboost_program_options-something-x64-1_72.a.

@rok-cesnovar rok-cesnovar merged commit 446c50a into develop Jun 16, 2020
@rok-cesnovar rok-cesnovar deleted the feature/888-stansummary-ci-arg branch June 16, 2020 20:15
@mitzimorris
Copy link
Member Author

@rok-cesnovar many many thanks!!! beginning to consider you a windows makefile god.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants