Skip to content

fix: pull changes from managed schemas separately#4155

Merged
sweatybridge merged 2 commits intodevelopfrom
fix-pull
Sep 13, 2025
Merged

fix: pull changes from managed schemas separately#4155
sweatybridge merged 2 commits intodevelopfrom
fix-pull

Conversation

@sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Sep 12, 2025

What kind of change does this PR introduce?

Bug fix #4068

What is the new behavior?

Using the pgkit/migra implementation, we can reliably pull triggers and policies from managed schemas.

Hence, we can start doing that automatically instead of printing a suggestion.

For user defined schemas, use original migra to avoid revoking permissions.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner September 12, 2025 16:05
@sweatybridge sweatybridge changed the title fix: pull managed schemas automatically fix: prompt to pull managed schemas Sep 12, 2025
@sweatybridge sweatybridge changed the title fix: prompt to pull managed schemas fix: prompt to pull changes in managed schemas Sep 12, 2025
@sweatybridge sweatybridge changed the title fix: prompt to pull changes in managed schemas fix: pull changes from managed schemas by default Sep 13, 2025
@sweatybridge sweatybridge changed the title fix: pull changes from managed schemas by default fix: pull changes from managed schemas separately Sep 13, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17692370276

Details

  • 18 of 63 (28.57%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.792%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/pull/pull.go 18 63 28.57%
Files with Coverage Reduction New Missed Lines %
internal/db/pull/pull.go 1 59.52%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 17678821493: -0.2%
Covered Lines: 6260
Relevant Lines: 11425

💛 - Coveralls

@sweatybridge sweatybridge merged commit 2b4de13 into develop Sep 13, 2025
11 checks passed
@sweatybridge sweatybridge deleted the fix-pull branch September 13, 2025 05:37
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing grants in generated migration generated with version 2.33.0 and above (db pull --linked)

2 participants