Skip to content
This repository was archived by the owner on Jun 4, 2022. It is now read-only.
/ grid Public archive
This repository was archived by the owner on Jun 4, 2022. It is now read-only.

Grid does not handle Commas #117

@J0

Description

@J0

Bug report

The grid does not properly handle entries with values that have commas.

Describe the bug

Query currently sent via request in the grid

delete from public."Vendor" where vendor_name in ('Molina','Nelson and Barnes' ...) and total_employees in ('49','73','107','51','48');

Query which should be sent

delete from public."Vendor" where vendor_name in ('Molina, Nelson and Barnes' ... ) and total_employees in (89,49,73,107,51,48);

To Reproduce

See Video:

Expected behavior

'John, Bob and Billy' should not be split into 'John' , 'Bob and Billy'

Screenshots

Relevant files: sqlRowService.ts

System information

  • OS: macOS
  • Browser (if applies) Firefox
  • Version of supabase-js: NA
  • Version of Node.js: NA

Additional context

https://github.com/supabase/grid/blob/5e62e6c87ce42c10f1096a9f45efb631143f4de0/src/services/row/SqlRowService.ts#L54-L57

NA

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions