Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Dec 29, 2025

This PR fixes a few issues as a follow up to #851

  1. The referenced types file needs to be a relative path. Otherwise, TS thinks it's a package name and you get an error in the tsconfig.json file such as:
Cannot find type definition file for 'worker-configuration.d.ts'.
  The file is in the program because:
    Entry point of type library 'worker-configuration.d.ts' specified in compilerOptions
  1. The preview port needs to be 4173 so that it works with the Playwright command which targets the same port. Otherwise, wrangler dev defaults to port 8080 and the Playwright test:e2e script fails

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025

🦋 Changeset detected

Latest commit: 271ea16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 29, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@866
npx https://pkg.pr.new/sveltejs/cli/sv@866

commit: 387cac1

@teemingc teemingc changed the title fix: use relative path for worker-configuration type fix: Cloudflare adapter integrations Dec 29, 2025
Copy link
Contributor

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small changeset tweaks, LGTM

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manuel3108 manuel3108 merged commit c9117dc into main Dec 30, 2025
6 of 7 checks passed
@manuel3108 manuel3108 deleted the teemingc-patch-1 branch December 30, 2025 07:11
@github-actions github-actions bot mentioned this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants