clean up static Map/Set/etc to avoid races and leaks#198
Merged
svanteschubert merged 4 commits intomasterfrom Dec 19, 2022
Merged
clean up static Map/Set/etc to avoid races and leaks#198svanteschubert merged 4 commits intomasterfrom
svanteschubert merged 4 commits intomasterfrom
Conversation
... as far as possible - the easy cases.
The "javax.activation" package was removed from JDK9, and is now maintained by Eclipse, and is surely excessive for this functionality. The fallback code here that is using a static map is mainly for file types one would expect to be common on a 1990s Solaris workstation. It turns out that there is a URLConnection.guessContentTypeFromName() since forever so just use that.
mUrlToPrefix looks safe currently, might get inited twice but not a problem.
... and mAttributeTypes.
svanteschubert
approved these changes
Dec 19, 2022
Contributor
svanteschubert
left a comment
svanteschubert
left a comment
There was a problem hiding this comment.
Thank you, Michael!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully the OdfNamespace one won't grow to any measurable size, otherwise will have to be moved somewhere non-static.