Adding casts to the if test so it passes on GPU#528
Merged
karllessard merged 2 commits intotensorflow:masterfrom Mar 26, 2024
Merged
Adding casts to the if test so it passes on GPU#528karllessard merged 2 commits intotensorflow:masterfrom
karllessard merged 2 commits intotensorflow:masterfrom
Conversation
Collaborator
|
Was this reported to TF core? Or is it an eigen problem? |
Collaborator
|
As we plan to upgrade to TF2.16, let see if the bug is still there before merging this |
Collaborator
Author
|
The if test without this patch still fails on GPU with TF 2.16 (#531). |
karllessard
approved these changes
Mar 26, 2024
Collaborator
karllessard
left a comment
karllessard
left a comment
There was a problem hiding this comment.
Ideally we would wrap this .neg operation with our own that would take care of the casting. But let's merge it so at least the build won't fail on GPUs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ops.math.negcauses eigen to segfault on GPUs now we've upgraded to TF 2.15. This PR fixes the one test where we do that so that there are casts around it. Not sure how to indicate that users shouldn't use this op on GPU as the op definition accepts ints and it's autogenerated.