[secu] update package.json files to resolve security alerts#6448
Merged
mattsoulanille merged 3 commits intomasterfrom May 25, 2022
Merged
[secu] update package.json files to resolve security alerts#6448mattsoulanille merged 3 commits intomasterfrom
mattsoulanille merged 3 commits intomasterfrom
Conversation
mattsoulanille
approved these changes
May 25, 2022
Member
mattsoulanille
left a comment
There was a problem hiding this comment.
Thanks for removing all these unused packages! LGTM.
Reviewed 30 of 30 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @jinjingforever)
tfjs-backend-wasm/package.json line 71 at r2 (raw file):
"karma-jasmine": "~1.1.1", "karma-typescript": "~5.5.1", "karma-typescript-es6-transform": "^5.0.2",
These are necessary because tfjs-backend-wasm still builds js and tests outside of Bazel even though it uses Bazel to run emscripten.
Code quote:
"jasmine": "~3.1.0",
"jasmine-core": "~3.1.0",
"karma": "^6.3.16",
"karma-browserstack-launcher": "~1.6.0",
"karma-chrome-launcher": "~2.2.0",
"karma-firefox-launcher": "~1.1.0",
"karma-jasmine": "~1.1.1",
"karma-typescript": "~5.5.1",
"karma-typescript-es6-transform": "^5.0.2",tfjs-node-gpu/package.json line 57 at r1 (raw file):
"node-fetch": "~2.6.1", "node-gyp": "~5.0.3", "nyc": "^15.1.0",
note to self: node-gyp isn't necessary because node-pre-gyp wraps it.
Code quote:
"node-gyp": "~5.0.3",
jinjingforever
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up the package.json files for directory migrated to bazel.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is