React native update tfjs to 4.2.0#7451
Merged
mattsoulanille merged 4 commits intotensorflow:masterfrom Mar 7, 2023
Merged
Conversation
Add missing definitions for setTimeoutCustom and isTypedArray to the react native platform
pyu10055
approved these changes
Mar 6, 2023
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @Linchenn)
Linchenn
approved these changes
Mar 6, 2023
Collaborator
Linchenn
left a comment
Linchenn
left a comment
There was a problem hiding this comment.
Thank you Matt for updating it!
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is forked from #7415 and only updates TFJS, including adding missing definitions for
isTypedArrayandsetTimeoutCustomto the react native platform. It does not attempt to update the demo app or any expo dependencies. These will be updated in a later PR.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is