Fix worker tests using the wrong paths in importScripts#8050
Merged
mattsoulanille merged 1 commit intotensorflow:masterfrom Nov 2, 2023
Merged
Fix worker tests using the wrong paths in importScripts#8050mattsoulanille merged 1 commit intotensorflow:masterfrom
mattsoulanille merged 1 commit intotensorflow:masterfrom
Conversation
Worker tests were getting the path for `importScripts` by referencing `location.origin`, but this is `blob://` when accessed from the worker context. Template `location.origin` from the main context into the worker source code instead of accessing the worker's version of `location.origin`.
Member
Author
Linchenn
approved these changes
Nov 2, 2023
Collaborator
Linchenn
left a comment
Linchenn
left a comment
There was a problem hiding this comment.
Thank you Matt for fixing this!
pyu10055
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker tests were getting the path for
importScriptsby referencinglocation.origin, but this isblob://when accessed from the worker context.Template
location.originfrom the main context into the worker source code instead of accessing the worker's version oflocation.origin.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.