Fix isWebGPUSupported throwing an error in node#8070
Merged
pyu10055 merged 2 commits intotensorflow:masterfrom Nov 14, 2023
Merged
Fix isWebGPUSupported throwing an error in node#8070pyu10055 merged 2 commits intotensorflow:masterfrom
pyu10055 merged 2 commits intotensorflow:masterfrom
Conversation
While node is not supported, 'isWebGPUSupported' should return false instead of throwing an error. This fixes pose-detection node tests, which use the same files as the browser tests.
pyu10055
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While node is not supported, 'isWebGPUSupported' should return false instead of throwing an error. This fixes pose-detection node tests, which use the same files as the browser tests.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.