Fix for windows installation #7341#8122
Merged
mattsoulanille merged 3 commits intotensorflow:masterfrom Jan 9, 2024
Merged
Conversation
Fix a problem with the installation on windows.
My problem on windows was that `./lib/napi-v9` directory didn't exist and `./scripts/deps-stage.js` on line **60** needed the path to symlink or copy the dll.
My fix was to make sure that the directory `napi-v9` exists with:
`await fs.mkdir(path.dirname(destLibTensorFlowPath), {recursive: true})`;
I'm solving the copy issue with this code.
pyu10055
approved these changes
Jan 8, 2024
Collaborator
|
/gcbrun |
mattsoulanille
approved these changes
Jan 9, 2024
Member
mattsoulanille
left a comment
mattsoulanille
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
For other reviewers, {recursive: true} prevents mkdir from throwing errors if the directory exists.
Member
|
/gcbrun |
This was referenced May 31, 2024
Closed
This was referenced Jun 20, 2024
Closed
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
This was referenced Sep 25, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Edit: Added one more commit, the mkdir function on my patch was misussed on the async call)
Fix a problem with the installation on windows.
My problem on windows was that
./lib/napi-v9directory didn't exist and./scripts/deps-stage.json line 60 needed the path to symlink or copy the dll.My fix was to make sure that the directory
napi-v9exists with:fs.mkdir(path.dirname(destLibTensorFlowPath), {recursive: true});I'm solving the copy issue with this code.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.