Quote props of DataType enum to prevent name mangling#8361
Merged
pyu10055 merged 1 commit intotensorflow:masterfrom Aug 23, 2024
Merged
Quote props of DataType enum to prevent name mangling#8361pyu10055 merged 1 commit intotensorflow:masterfrom
pyu10055 merged 1 commit intotensorflow:masterfrom
Conversation
These properties must be quoted since they are used by parseDtypeParam in tfjs-converter/src/operations/operation_mapper.ts to look up dtypes by string name. If they are not quoted, Closure will mangle their names.
Member
Author
|
b/352489112 |
Linchenn
approved these changes
Aug 23, 2024
Collaborator
Linchenn
left a comment
Linchenn
left a comment
There was a problem hiding this comment.
Great finding, thanks!
pyu10055
approved these changes
Aug 23, 2024
This was referenced Sep 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These properties must be quoted since they are used by parseDtypeParam in tfjs-converter/src/operations/operation_mapper.ts to look up dtypes by string name. If they are not quoted, Closure will mangle their names.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.