Add reactStrictMode as an option to render#1390
Merged
eps1lon merged 2 commits intotesting-library:mainfrom Apr 2, 2025
Merged
Add reactStrictMode as an option to render#1390eps1lon merged 2 commits intotesting-library:mainfrom
reactStrictMode as an option to render#1390eps1lon merged 2 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5be1d35:
|
eps1lon
approved these changes
Apr 2, 2025
Member
eps1lon
left a comment
There was a problem hiding this comment.
flawless. Thank you! Will merge once docs are settled.
Member
|
@all-contributors add @bernardobelchior for code, docs |
Contributor
|
I've put up a pull request to add @bernardobelchior! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add an ability to override the global
reactStrictModeconfiguration on a per-test basis.Why:
At MUI, our tests use a small wrapper around React Testing Library and had this functionality. However, it was broken in the upgrade to React 19 since
StrictModewon't double call effects on initial mount unlessStrictModeis rendered at the root of the tree. Since we were renderingReact.StrictModeinside the component passed to thewrapperproperty, effects aren't being called twice in React 19.How:
Added a
reactStrictModetorenderOptions.Checklist:
reactStrictModeinrendertesting-library-docs#1479