fix(diff): show in "Not in cache" if dir entry is missing #10844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this only works when second revision argument is missing, as otherwise we don't really check for missing cache entries.
skshetry
added
A: status
skshetry
commented
Aug 15, 2025
Comment on lines
+48
to
+51
| # we need to get unknown and unchanged entries to tell whether | ||
| # the object is missing from the cache or not. | ||
| with_unknown=with_missing, | ||
| with_unchanged=with_missing, |
Collaborator
Author
There was a problem hiding this comment.
We only check for missing cache items if the second argument is missing in dvc diff. So, this fix will only work in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this only works when second revision argument is missing, as otherwise we don't really check for missing cache entries.
Closes #7661.