Skip to content

Conversation

@vorj
Copy link
Contributor

@vorj vorj commented Jan 6, 2026

Pathspec v1 has been released, and with current DVC dependency setup it gets installed by default. However, Pathspec v1 is not compatible with current DVC, which causes DVC to fail with the following error: unexpected error - cannot import name '_DIR_MARK' from 'pathspec.patterns.gitwildmatch' (/path/to/lib/python3.10/site-packages/pathspec/patterns/gitwildmatch.py)

This PR prevents the issue by explicitly pinning pathspec to <1 , ensuring a compatible version is installed and DVC works as expected.

@github-project-automation github-project-automation bot moved this to Backlog in DVC Jan 6, 2026
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.97%. Comparing base (2431ec6) to head (7dfa1bf).
⚠️ Report is 178 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10948      +/-   ##
==========================================
+ Coverage   90.68%   90.97%   +0.29%     
==========================================
  Files         504      505       +1     
  Lines       39795    41022    +1227     
  Branches     3141     3244     +103     
==========================================
+ Hits        36087    37321    +1234     
- Misses       3042     3063      +21     
+ Partials      666      638      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing and bringing the issue to my attention. I’d like to support the new version, but it seems that would require a substantial change.

@skshetry skshetry merged commit 3c77443 into treeverse:main Jan 6, 2026
47 of 48 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in DVC Jan 6, 2026
@cpburnz cpburnz mentioned this pull request Jan 6, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants