feat(isIdentityCard): Add PL locale

[wiktorwojcik112]

Add isPESEL validation.

PESEL is a polish national identification number. Validator checks whether provided string follows criteria of
valid PESEL.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1745 (ec4801d) into master (c899b31) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1745   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2015      2027   +12     
  Branches       454       456    +2     
=========================================
+ Hits          2015      2027   +12     

Impacted Files	Coverage Δ
src/lib/isIdentityCard.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...ec4801d. Read the comment docs.

[fedeci]

Does it have anything to do with isIdentityCard? I am quite in disagreement with adding a specific validator for a specific country code.

[wiktorwojcik112]

Does it have anything to do with isIdentityCard? I am quite in disagreement with adding a specific validator for a specific country code.

I checked and it would fit there. I will add this PESEL validator to isIdentityCard.

[tux-tn]

Thank you for your PR @wiktorwojcik112
Totally agree with @fedeci this validator should be added as a locale to isIdentityCard. Please make the necessary changes and add tests for the uncovered line in your code

[tux-tn]

Thank you for updating your PR @wiktorwojcik112 can you please fix the linter issue and add the missing test cases to bring back coverage to 100%.
I suggest you run tests locally before pushing new code (using yarn test or npm run test)
EDIT: Can you please change the PR title to specify you are adding a new locale to isIdentityCard and not a new validator (The PR title will be the commit message when the PR is merged and the actual title is misleading)

[wiktorwojcik112]

Ok. I fixed linter error and changed title, but I still can't figure out how to solve coverage issue.

[tux-tn]

Ok. I fixed linter error and changed title, but I still can't figure out how to solve coverage issue.

That's tricky but you need to find a test example where the last digit of PESEL number equals 10 minus your modulo.
As i told you earlier the uncovered execution path is lastDigit === 10 - modulo

[wiktorwojcik112]

Ok. I fixed linter error and changed title, but I still can't figure out how to solve coverage issue.

That's tricky but you need to find a test example where the last digit of PESEL number equals 10 minus your modulo. As i told you earlier the uncovered execution path is lastDigit === 10 - modulo

Everything should be good now.

[tux-tn]

Thank you @wiktorwojcik112 can you please address my latest comment concerning istanbul ignore else ?

[tux-tn]

LGTM 🎉 Thank you for taking the time to quickly address all the comments

[wiktorwojcik112]

LGTM 🎉 Thank you for taking the time to quickly address all the comments

It was nice working with you. Thank you all for help. Take care!

[profnandaa]

LGTM. thanks for your contrib! 🎉