refactor: run scripts in parallel for build and clean#1747
refactor: run scripts in parallel for build and clean#1747profnandaa merged 2 commits intovalidatorjs:masterfrom sachinraja:run-parallel
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2015 2015
Branches 454 454
=========================================
Hits 2015 2015 Continue to review full report at Codecov.
|
| "clean:es": "rimraf es", | ||
| "clean:browser": "rimraf validator*.js", | ||
| "clean": "npm run clean:node && npm run clean:browser && npm run clean:es", | ||
| "clean": "run-p clean:*", |
There was a problem hiding this comment.
Isn't the same result achieved using a single & and without having to add another dep?
| "clean": "run-p clean:*", | |
| "clean": "npm run clean:node & npm run clean:browser & npm run clean:es", |
There was a problem hiding this comment.
That doesn't work on Windows (with cmd.exe)
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉 ! Thank you for the PR @sachinraja
tux-tn
added
🎉 first-pr
maintenance
ready-to-land
|
Hey, just curious, what is does the |
|
@sachinraja it's an internal way of organizing things between the project collaborators. The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged. Later when enough PRs have been stacked, a maintainer will merge your PR alongside other |
|
Thanks @sachinraja for your PR! 🎉 |
|
Got it, thanks for explaining @tux-tn |
4 participants
Run
building for browser, node, and es in parallel. Same forclean. This speeds up both commands.Checklist