Added validation for Bermuda on isMobilePhone#1769
Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom Oct 30, 2021
Merged
Added validation for Bermuda on isMobilePhone#1769profnandaa merged 3 commits intovalidatorjs:masterfrom
profnandaa merged 3 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2031 2038 +7
Branches 458 460 +2
=========================================
+ Hits 2031 2038 +7
Continue to review full report at Codecov.
|
tux-tn
requested changes
Oct 18, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your pr @HackProAIT !
Can you please address my comments below?
tux-tn
added
🎉 first-pr
🧹 needs-update
tux-tn
added
hacktoberfest-accepted
ready-to-land
Member
|
@HackProAIT - pls fix the merge conflict on README and we should be good to go. |
profnandaa
added
the
mc-to-land
Member
|
You resolved this wrongly though, did away with the latest |
profnandaa
approved these changes
Oct 30, 2021
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
* Added validation for Bermuda on isMobilePhone * changed regex for bermuda to disable landline no
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Added validation for Bermuda on isMobilePhone * changed regex for bermuda to disable landline no
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Added validation for Bermuda on isMobilePhone * changed regex for bermuda to disable landline no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist