Fixes #1761 for Bangladesh and Myanmar Mobile Validation and Test #1813
Merged
profnandaa merged 7 commits intovalidatorjs:masterfrom Nov 17, 2021
Merged
Fixes #1761 for Bangladesh and Myanmar Mobile Validation and Test #1813profnandaa merged 7 commits intovalidatorjs:masterfrom
profnandaa merged 7 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2059
Branches 464 464
=========================================
Hits 2059 2059
Continue to review full report at Codecov.
|
tux-tn
requested changes
Oct 27, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Hello @ferdousulhaque and thank you for your PR!
Can you please address the comments below?
tux-tn
added
🎉 first-pr
🧹 needs-update
tux-tn
requested changes
Nov 8, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM ! Thank you for addressing my comments. Can you please fix merge conflicts and we should be good to go
Contributor
Author
|
@tux-tn conflicts resolved. :) |
tux-tn
added
ready-to-land
Contributor
Author
|
@tux-tn Please help to add tag |
Member
|
Done |
profnandaa
approved these changes
Nov 17, 2021
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and Addition, please ignore the previous pull request.
Checklist