feat(isMobilePhone): regex for Burkina Faso fr-BF and Namibia en-NA locales#1834
feat(isMobilePhone): regex for Burkina Faso fr-BF and Namibia en-NA locales#1834ZeeMangena wants to merge 8 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib. I'll update the title to include Namibia
| 'en-KE': /^(\+?254|0)(7|1)\d{8}$/, | ||
| 'en-MT': /^(\+?356|0)?(99|79|77|21|27|22|25)[0-9]{6}$/, | ||
| 'en-MU': /^(\+?230|0)?\d{8}$/, | ||
| 'en-NA': /^(\+?264|0)(6|8)\d{7}$/, |
There was a problem hiding this comment.
Isn't BF's locale fr-BF? https://www.localeplanet.com/icu/fr-BF/index.html
There was a problem hiding this comment.
scratch that, seen your changes below; perhaps you can have this change as separate PR.
There was a problem hiding this comment.
Ok, never mind, I'll just update the title of the PR to include both Namibia and BF.
profnandaa
changed the title
|
@ZeeMangena -- please fix the merge conflict and we should be good to go. |
profnandaa
added
mc-to-land
profnandaa
changed the title
…ocales chore: squashed commits from #1834 feat(isMobilePhone): regex for Namibia locale fix(isMobilePhone): removing telephone validation fix(isMobliePhone): regex now validates as intended fix(isMobilePhone): requiring phone number prefixes in validation feat(isMobilePhone): regex for Burkina Faso locale fix(isMobilePhone): removing code intended for a different branch fix(isMobilePhone): Making plus sign optional feat(isMobilePhone): regex for Burkina Faso locale
|
This changed has now been added here #1851 // however, please proceed and merge the rest of your work into one PR. Thanks so much for your contributions! 🎉 |
2 participants
Add new regex for Burkina Faso (fr-BF) mobile phone numbers in isMobilePhone
Checklist