feat(isUUID) - Add support for validation of version v1 and v2#1848
Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom Oct 31, 2021
Merged
feat(isUUID) - Add support for validation of version v1 and v2#1848profnandaa merged 3 commits intovalidatorjs:masterfrom
profnandaa merged 3 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2052 2052
Branches 463 463
=========================================
Hits 2052 2052
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Oct 30, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉 Thank you for your PR !
profnandaa
approved these changes
Oct 31, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* fix(isUUID) for null version argument supply * improve(isUUID) validation for version 1 and 2
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* fix(isUUID) for null version argument supply * improve(isUUID) validation for version 1 and 2
lpicchi
added a commit
to lpicchi/DefinitelyTyped
that referenced
this pull request
May 4, 2023
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
thefat32
pushed a commit
to thefat32/DefinitelyTyped
that referenced
this pull request
May 5, 2023
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
thefat32
added a commit
to thefat32/DefinitelyTyped
that referenced
this pull request
May 5, 2023
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
Merged
8 tasks
peterblazejewicz
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
May 6, 2023
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
Desplandis
pushed a commit
to Desplandis/DefinitelyTyped
that referenced
this pull request
Jul 3, 2023
…Typed#65406) New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation support for UUID version 1 and version 2. Also a minor fix was made for returning undefined instead of returning a boolean.
Checklist