feat(isMACAddress): add EUI-64 validation#1865
Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom Nov 17, 2021
WikiRik:mac-eui64-support
Merged
feat(isMACAddress): add EUI-64 validation#1865profnandaa merged 3 commits intovalidatorjs:masterfrom WikiRik:mac-eui64-support
profnandaa merged 3 commits intovalidatorjs:masterfrom
WikiRik:mac-eui64-support
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1865 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2072 +13
Branches 464 472 +8
=========================================
+ Hits 2059 2072 +13
Continue to review full report at Codecov.
|
Member
Author
|
To be honest, I do not really know. I would be happy to refer to it as MacAddr6 and 8. Do you think I should refactor it to numberOfBits? Or some other suggestion? |
Co-authored-by: Sarhan Aissi <tux-tn@users.noreply.github.com>
Member
profnandaa
approved these changes
Nov 17, 2021
Member
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for validating against EUI-64 as well as the previous EUI-48. This corresponds with the macaddr8 type in postgres.
Checklist