feat(isTaxID): Canadian Social Insurance Number (SIN) validator#1867
feat(isTaxID): Canadian Social Insurance Number (SIN) validator#1867profnandaa merged 6 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1867 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2084 +25
Branches 464 472 +8
=========================================
+ Hits 2059 2084 +25
Continue to review full report at Codecov.
|
|
Thank you for your PR. Isn't SIN a Tax ID for individuals and thereby should be part of |
That is a good question. Actually I don't know. Let me ask my Canadian friends and google to clarify that. |
Okay, I have got an answer below
So, I have redone my work. I hope it's good to go now. |
tux-tn
left a comment
There was a problem hiding this comment.
Mostly LGTM 🎉
Thank you for your PR! Can you just address my comment below?
tux-tn
left a comment
There was a problem hiding this comment.
LGTM ! Thank you for your contribution
profnandaa
left a comment
There was a problem hiding this comment.
LGTM. thanks for your contribution! 🎉
Here I have implemented separate validator to verify that an input is a valid SIN (Social Insurance Number in Canada).
I realised that you use a combination of ISO 639-1 + ISO 3166-1 alpha-2 to identify locale in the
isTaxIDvalidator, so I have applied appropriate two locales for the Canada -en-CAandfr-CA.Also I have added a few additional values of postal codes in Ukraine, Poland and Canada to improve autotesting isPostalCode validator.
Checklist