Add whitelist host to isEmail validation.#1920
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Oct 17, 2022
Merged
Add whitelist host to isEmail validation.#1920profnandaa merged 2 commits intovalidatorjs:masterfrom
profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1920 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2097 2099 +2
Branches 473 474 +1
=========================================
+ Hits 2097 2099 +2
Continue to review full report at Codecov.
|
profnandaa
approved these changes
Apr 22, 2022
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib 🎉
// And sorry for the delay in reviewing this.
profnandaa
added
🎉 first-pr
mc-to-land
Member
|
Just fix the m/c on README and we should be good to go. |
3 tasks
Contributor
Author
Hi, Thank you. The conflict has been fixed! 🚀 |
|
Can this be merged and closed now? |
rubiin
added
ready-to-land
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add host whitelist to is Email validation.
closes: #1912
Add a new option (whitelist host) to isEmail options to check if the email domain is in it or not, if it was not in the whitelist host it fails.
Checklist