feat(isLicensePlate): updated German license plate validation

[bennetfabian]

In this PR I updated all the available area codes (https://de.wikipedia.org/wiki/Liste_der_Kfz-Kennzeichen_in_Deutschland) for Germany's license plate validation regex.

Also I decided it will be easier to update and maintain in the future if all area codes are in alphabetical order. There are no performance or speed drawbacks with alphabetical sorting.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1945 (290debb) into master (c1b21a9) will not change coverage.
The diff coverage is n/a.

❗ Current head 290debb differs from pull request most recent head 080f7df. Consider uploading reports for the commit 080f7df to get more accurate results

@@            Coverage Diff            @@
##            master     #1945   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2085      2085           
  Branches       472       472           
=========================================
  Hits          2085      2085           

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b21a9...080f7df. Read the comment docs.

[bennetfabian]

I'd like kindly ask you to take a look at my change. Only carefully switched out the area code part of the regex so it should be safe to say it isn't breaking anything.
@chriso @profnandaa @ezkemboi @tux-tn

[rubiin]

please add tests for the new code as well

[bennetfabian]

please add tests for the new code as well

Sorry for disagreeing but exactly why?
I understand the importance of tests but there are already 22 test values supposed to be valid and 5 supposed to be invalid.
Yes, of course, I can think of a few more but especially when comparing to other methods that have less tests I think 22 valid & 5 invalid is more than solid enough.

So why should there be more?
The format remains the same as my PR doesn't even touch the format and structure validation but only updates the available area/district codes.

———

But thanks for commenting. I had another look at the regex and there is one obsolete | operator. Will fix in the next hour.

[rubiin]

Well the thing is since there is a code update, the new tests would ensure that the change agrees to the final output. Otherwise things would break in future. Also it would help review the code more fatser

[bennetfabian]

Well the thing is since there is a code update, the new tests would ensure that the change agrees to the final output. Otherwise things would break in future. Also it would help review the code more fatser

Okay, I agree. Better safe than sorry. Will think of a few more tests.

[rubiin]

Well the thing is since there is a code update, the new tests would ensure that the change agrees to the final output. Otherwise things would break in future. Also it would help review the code more fatser

Okay, I agree. Better safe than sorry. Will think of a few more tests.

Yeah thats the reason :)

[bennetfabian]

@ezkemboi Could you merge please?

[rubiin]

Thankyou for the contribution 🎉