Fixed missing SK locale for isPostalCode#1957
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Jun 30, 2022
tfilo:missing-locale-in-readme
Merged
Fixed missing SK locale for isPostalCode#1957profnandaa merged 2 commits intovalidatorjs:masterfrom tfilo:missing-locale-in-readme
profnandaa merged 2 commits intovalidatorjs:masterfrom
tfilo:missing-locale-in-readme
Conversation
In source code you already support SK locale for few years, but it was missing in documentation. validator.js/src/lib/isPostalCode.js
Codecov Report
@@ Coverage Diff @@
## master #1957 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2099 2099
Branches 474 474
=========================================
Hits 2099 2099 Continue to review full report at Codecov.
|
Member
|
Thanks for the catch, sorry we've a merge conflict coz of the other PR changes. Could you update? |
Contributor
Author
I did merge of master into my branch. Now it should have no conflict. |
profnandaa
approved these changes
Jun 30, 2022
This was referenced Jun 3, 2024
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In source code you already support SK locale for few years, but it was missing in documentation.
validator.js/src/lib/isPostalCode.js
Fixed missing SK locale for isPostalCode in readme file.
Fixed missing SK locale for isPostalCode in readme file.
Checklist