Skip to content

feat(isMobilePhone): Added regex for Aruba nl-AW#1985

Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom
adida948:main
Jul 3, 2022
Merged

feat(isMobilePhone): Added regex for Aruba nl-AW#1985
profnandaa merged 3 commits intovalidatorjs:masterfrom
adida948:main

Conversation

@adida948
Copy link
Contributor

@adida948 adida948 commented Jun 13, 2022 •
edited
Loading

Added validation for Aruba on isMobilePhone.
referred issue: #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #1985 (8eef656) into master (37cbd5c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1985   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2099           
  Branches       474       474           
=========================================
  Hits          2099      2099
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cbd5c...8eef656. Read the comment docs.

rubiin
rubiin previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @profnandaa

tux-tn
tux-tn previously approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for your PR @adida948

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Jun 24, 2022
@profnandaa
Copy link
Member

profnandaa commented Jun 30, 2022

@rubiin -- you'd an invite to join the org, let me resend. Thanks for your review on this too!

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 30, 2022
profnandaa
profnandaa previously approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the m/c which I'll fix on a bulk PR before release.

@adida948 adida948 dismissed stale reviews from profnandaa, tux-tn, and rubiin via b1433b9 July 1, 2022 16:16
@adida948
Copy link
Contributor Author

adida948 commented Jul 1, 2022

HI, let me know if there is anything else needed from my side.

@adida948 adida948 requested review from profnandaa, rubiin and tux-tn July 1, 2022 16:23
rubiin
rubiin requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Readme there is still the merge markers. please remove that

@adida948
Copy link
Contributor Author

adida948 commented Jul 1, 2022

@rubiin tried the github UI. I messed up the update. Did it from command line now.
thanks. I have removed them

@adida948 adida948 requested a review from rubiin July 1, 2022 17:46
@profnandaa profnandaa merged commit 6fb8bb5 into validatorjs:master Jul 3, 2022
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@fossabot fossabot bot mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

@tux-tn tux-tn Awaiting requested review from tux-tn

Assignees

No one assigned

Labels

🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adida948 @profnandaa @tux-tn @rubiin

Comments