feat(isBefore): allow usage of options object#2088
Merged
rubiin merged 37 commits intovalidatorjs:masterfrom Mar 27, 2025
Merged
feat(isBefore): allow usage of options object#2088rubiin merged 37 commits intovalidatorjs:masterfrom
rubiin merged 37 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 113 +3
Lines 2510 2531 +21
Branches 633 643 +10
===========================================
+ Hits 2510 2530 +20
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
reviewed
Oct 25, 2022
Member
WikiRik
left a comment
There was a problem hiding this comment.
Few remarks, thanks for working on this!
WikiRik
reviewed
Oct 25, 2022
Member
WikiRik
left a comment
There was a problem hiding this comment.
Few final comments so that this is consistent with my changes to isAfter and the project in general, but apart from these we should be good I think
b4167b7 to
e907cde
Compare
Contributor
Author
|
I think this should be good to go :). |
WikiRik
requested changes
Feb 5, 2023
Member
WikiRik
left a comment
There was a problem hiding this comment.
Few remarks to be more in line with how isAfter was done, but those should be my last
WikiRik
reviewed
Feb 5, 2023
WikiRik
previously approved these changes
Mar 26, 2025
WikiRik
previously approved these changes
Mar 26, 2025
WikiRik
approved these changes
Mar 26, 2025
rubiin
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements steps 1 and 2 of #1874 for
isBeforeand builds upon #2075.This PR extracts tests for
isBeforeinto a separate test file ⇾test/validators/isBefore.test.js(inspired by #1793).This PR also renames the proposed
dateoption tocomparisonDate, because it is more explicit. If verified, it should be implemented in #2075 as well.Checklist