fix(isMimeType): Fix MIME Types with underscores not getting matched#2120
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Jan 29, 2023
Merged
fix(isMimeType): Fix MIME Types with underscores not getting matched#2120profnandaa merged 2 commits intovalidatorjs:masterfrom
profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2335 2335
Branches 586 586
=========================================
Hits 2335 2335
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
WikiRik
previously approved these changes
Dec 6, 2022
2 tasks
braaar
previously approved these changes
Dec 7, 2022
songyuew
previously approved these changes
Jan 5, 2023
rubiin
previously approved these changes
Jan 23, 2023
profnandaa
added
the
mc-to-land
in preparation for fixing validatorjs#2119
fixes a few valid MIME types not getting matched fixes validatorjs#2119
pano9000
force-pushed
the
fix_isMimeType_#2119
branch
from
f8b4812 to
c1e7fd8
Compare
WikiRik
approved these changes
Jan 28, 2023
rubiin
removed
the
mc-to-land
rubiin
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
_(underscore) to themimeTypeSimpleRegExp to fix valid MIME types not getting matched.Kindly check #2119 for more details
This fixes #2119
Checklist
[ ] README updated (where applicable)