fix(isEmail): fixed isFQDN still checking email length when ignore_max_length is true#2128
Closed
sakhmedbayev wants to merge 2 commits intovalidatorjs:masterfrom
Closed
fix(isEmail): fixed isFQDN still checking email length when ignore_max_length is true#2128sakhmedbayev wants to merge 2 commits intovalidatorjs:masterfrom
isFQDN still checking email length when ignore_max_length is true#2128sakhmedbayev wants to merge 2 commits intovalidatorjs:masterfrom
Conversation
…_max_length` is `true`
sakhmedbayev
changed the title
isFQDN still checking email length when ignore_max_length is falseisFQDN still checking email length when ignore_max_length is true
WikiRik
requested changes
Dec 14, 2022
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Code changes look good, don't forget to document the new option for isFQDN in the README
Contributor
Author
@WikiRik, thanks, documented |
WikiRik
approved these changes
Dec 15, 2022
rubiin
approved these changes
Jan 23, 2023
profnandaa
approved these changes
Jan 28, 2023
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix! 🎉
profnandaa
added
mc-to-land
Merged
Member
|
combined in #2170 |
profnandaa
added a commit
that referenced
this pull request
Feb 1, 2023
fix(isEmail): fixed `isFQDN` still checking email length when `ignore_max_length` is `true` profnandaa: clean-up #2128 --------- Co-authored-by: Said Akhmedbayev <said.akh@gmail.com> Co-authored-by: Said Akhmedbayev <said.akhmedbayev@accenture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue when the
ignore_max_lengthoption was not honored (did not have any effect) since theisFQDNfunction had its own check for the email parts length.Checklist