feat(isMobilePhone): Add regex for Somalia so-SO#2175
Merged
profnandaa merged 4 commits intovalidatorjs:masterfrom Feb 8, 2023
Merged
feat(isMobilePhone): Add regex for Somalia so-SO#2175profnandaa merged 4 commits intovalidatorjs:masterfrom
profnandaa merged 4 commits intovalidatorjs:masterfrom
Conversation
profnandaa
reviewed
Feb 2, 2023
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
This LGTM, we're just about to make our next release and the preps are done. Unfortunately this will miss the train but should be on the next one.
Please fix the merge conflicts.
profnandaa
added
mc-to-land
ezkemboi
previously approved these changes
Feb 6, 2023
Member
ezkemboi
left a comment
ezkemboi
left a comment
There was a problem hiding this comment.
LGTM.
Please check @rubiin @profnandaa @tux-tn
ezkemboi
reviewed
Feb 7, 2023
ezkemboi
reviewed
Feb 7, 2023
ezkemboi
approved these changes
Feb 7, 2023
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2324 2324
Branches 586 586
=========================================
Hits 2324 2324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rubiin
approved these changes
Feb 7, 2023
profnandaa
approved these changes
Feb 8, 2023
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added regex validation for Somalia (so-SO) mobile phone numbers, country codes referenced from these documents:
Checklist