feat(IsFQDN): Add a test that asserts numeric chars in tld are rejected by default.#2222
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Aug 3, 2023
Merged
Conversation
Signed-off-by: Aalekh Patel <aalekh@protectchildren.ca>
Signed-off-by: Aalekh Patel <aalekh@protectchildren.ca>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2222 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2405 2405
Branches 604 604
=======================================
Hits 2404 2404
Partials 1 1 ☔ View full report in Codecov by Sentry. |
WikiRik
approved these changes
May 25, 2023
Member
WikiRik
left a comment
There was a problem hiding this comment.
It seems that we are not testing for solely allow_numeric_tld: true so this looks good to me. We'll move the other tests for isFQDN to this file later
profnandaa
approved these changes
Aug 3, 2023
Member
|
Thanks for the PR! |
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This was referenced Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(isFQDN): Add a test that asserts numeric chars in tlds are rejected by default.
Add a test that cements the default behaviour of
isFQDNof rejecting tld with numeric data, and also that valiation can be relaxed by passing{allow_numeric_tld: true}Checklist