feat(isEmail) extend to enable allow_underscores in domain#2229
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Aug 3, 2023
Merged
feat(isEmail) extend to enable allow_underscores in domain#2229profnandaa merged 2 commits intovalidatorjs:masterfrom
profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
added 2 commits
May 24, 2023 15:27
…tion, allowing successful validation of email addresses containing domains with underscores
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2229 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2405 2405
Branches 604 604
=======================================
Hits 2404 2404
Partials 1 1
☔ View full report in Codecov by Sentry. |
WikiRik
approved these changes
May 25, 2023
Contributor
Author
|
thanks for the review @WikiRik +1 |
|
This would be really helpful. |
rubiin
approved these changes
Jun 12, 2023
Contributor
Author
|
thanks for the review @rubiin +1 |
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow successful validation of email addresses containing domains with underscores
Add
allow_underscoresoption toisEmail, pass through value toisFQDNvalidator.An example underscore domain in the wild for reference
Checklist