Modified symbolRegex in isStrongPassword to include '\'#2278
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Apr 27, 2024
Merged
Modified symbolRegex in isStrongPassword to include '\'#2278profnandaa merged 2 commits intovalidatorjs:masterfrom
profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2454 2454
Branches 619 619
=======================================
Hits 2453 2453
Partials 1 1
☔ View full report in Codecov by Sentry. |
Member
|
Thanks for the PR! Don't forget to add additional tests before we can review this |
WikiRik
approved these changes
Sep 12, 2023
manojmula
approved these changes
Dec 1, 2023
profnandaa
approved these changes
Apr 27, 2024
This was referenced Sep 20, 2024
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isStrongPassword - Bug fix
I modified the special character regex a little bit to add validation for '\' character. I worked on this based on an issue in the repository
Checklist