Skip to content

feat(isISO31661Numeric): Add validation for ISO 3166-1 numeric country codes#2399

Merged
profnandaa merged 4 commits intovalidatorjs:masterfrom
RobinvanderVliet:add-iso-31661-numeric
May 10, 2024
Merged

feat(isISO31661Numeric): Add validation for ISO 3166-1 numeric country codes#2399
profnandaa merged 4 commits intovalidatorjs:masterfrom
RobinvanderVliet:add-iso-31661-numeric

Conversation

@RobinvanderVliet
Copy link
Contributor

The ISO 3166-1 standard contains three sets of country codes: two-letter, three-letter, and three-digit. Currently, we have a validator for two-letter codes (isISO31661Alpha2) and three-letter codes (isISO31661Alpha3), but not for three-digit codes. This pull request addresses that.

References

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin added the ✅ LGTM label May 9, 2024
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@profnandaa profnandaa merged commit 79f5d18 into validatorjs:master May 10, 2024
@RobinvanderVliet RobinvanderVliet deleted the add-iso-31661-numeric branch May 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments